feat(logs): add Troubleshoot in Chat button for errored runs by waleedlatif1 · Pull Request #5341 · simstudioai/sim

waleedlatif1 · 2026-07-01T23:18:39Z

Summary

Adds a Troubleshoot in Chat button to the log details panel for errored runs (failed status, has an executionId, not a Chat/mothership run).
Clicking it tags the failed run as a logs context (executionId) and auto-sends a message to Chat asking Sim to investigate and fix the error — the server resolves the tagged run into the agent's context, so it sees the full error.
Ports the old copilot "Fix in Chat" behavior to mothership and adds the run-ID tagging that never got carried over.
Cross-route handoff rides a one-shot MothershipHandoffStorage (localStorage) consumed exactly once on the home-surface mount, so the tagged run + prompt survive the Logs → Chat navigation. Consume clears atomically (fires once, even under StrictMode / reload).

Type of Change

New feature

Testing

Unit tests for MothershipHandoffStorage (round-trip + trim, one-shot consume, empty-message guard, max-age expiry clears).
type-check, biome, check:client-boundary, and check:api-validation all pass.
Verified the end-to-end path: button → handoff stored → /home mount consumes → sendMessage(msg, undefined, contexts) → POST /api/mothership/chat with createNewChat: true and the raw contexts (envelope + context schema are .passthrough(), so executionId survives) → processExecutionLogFromDb(executionId) injects the run error into the agent.

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Errored log runs now surface a "Troubleshoot in Chat" action in the log details panel. It tags the failed run as a logs context (executionId) and auto-sends a message to Chat asking Sim to investigate and fix the error, porting the old copilot "Fix in Chat" behavior to mothership and adding run-ID tagging. Cross-route handoff rides a one-shot MothershipHandoffStorage consumed once on the home surface mount, so the tagged run + prompt survive the navigation from Logs to Chat and the agent receives the full run error via the resolved logs context.

vercel · 2026-07-01T23:18:45Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Jul 2, 2026 12:13am

cursor · 2026-07-01T23:18:51Z

PR Summary

Medium Risk
New cross-route chat handoff and mothership event contract changes could affect existing “Fix in Chat” flows if consumption/preventDefault behavior regresses; scope is client-only with tests on the storage path.

Overview
Adds Troubleshoot in Chat on failed workflow runs in log details (requires executionId, excludes mothership-triggered runs). The action sends a prefilled prompt with a logs ChatContext tagging the run so Chat can investigate the failure.

Cross-surface delivery: sendMothershipMessage now accepts optional contexts, dispatches a cancelable event, and returns whether a mounted chat consumed it (preventDefault). Workspace home forwards contexts into sendMessage and, on the new-chat surface only, consumes a one-shot MothershipHandoffStorage handoff when no listener is mounted—otherwise log details stores the handoff and navigates to /home only after a successful write.

Includes unit tests for handoff store/consume (trim, one-shot, expiry, corruption). Log details overview rows get minor UI tweaks (Badge/Chip, less row hover).

^{Reviewed by Cursor Bugbot for commit 462f4cd. Configure here.}

greptile-apps · 2026-07-01T23:23:55Z

Greptile Summary

This PR adds a Troubleshoot in Chat button to the log details panel that activates for failed, non-mothership runs. It uses a two-path delivery: a cancelable custom DOM event (MOTHERSHIP_SEND_MESSAGE_EVENT) consumed in-place when Chat is already mounted, or a localStorage one-shot handoff (MothershipHandoffStorage) that survives navigation to the home surface.

browser-storage.ts: New MothershipHandoffStorage class with atomic clear-before-validate semantics, a 60-second max-age guard, and comprehensive unit tests including a regression for the previously-reported corrupted-entry bug.
events.ts: sendMothershipMessage gains an optional contexts argument, cancelable: true on the dispatched event, and a boolean return value so callers can detect whether a mounted consumer claimed the message.
log-details.tsx / home.tsx: The button and handleTroubleshoot callback build the logs context, attempt event delivery, fall back to store-and-navigate; the home surface consumes the handoff on mount (gated to !chatId to avoid claiming it on an existing chat route).

Confidence Score: 5/5

Safe to merge — the two-path delivery is correctly implemented, the atomic clear-before-validate pattern prevents stale entries, and all previously flagged issues have been addressed.

The handoff is one-shot by design: consume() clears unconditionally before any validity checks, so StrictMode double-mount and repeated sendMessage identity changes cannot replay the message. The store-then-navigate gate ensures no redirect occurs on a failed write. Existing callers of sendMothershipMessage are backward-compatible since the new contexts parameter is optional. Unit tests cover all edge cases introduced by this PR.

No files require special attention.

Important Files Changed

Filename	Overview
apps/sim/lib/core/utils/browser-storage.ts	Adds MothershipHandoffStorage with correct atomic clear-before-validate pattern; all edge cases (empty message, corrupted entry, expiry) are properly handled.
apps/sim/lib/core/utils/browser-storage.test.ts	New unit tests cover round-trip, one-shot semantics, empty-message guard, corrupted-entry tombstone, and max-age expiry — comprehensive coverage of the new class.
apps/sim/lib/mothership/events.ts	Adds optional contexts, cancelable event flag, and boolean return — backward-compatible with existing callers (terminal, console store) that ignore the return value.
apps/sim/app/workspace/[workspaceId]/home/home.tsx	Handoff consumer useEffect correctly gated to !chatId and uses atomic consume(); event handler correctly claims with preventDefault() before forwarding contexts to sendMessage.
apps/sim/app/workspace/[workspaceId]/logs/components/log-details/log-details.tsx	Adds canTroubleshoot guard and handleTroubleshoot callback with correct two-path delivery; navigation gated on successful store(); also refactors Version badge and Snapshot button to use EMCN components.

Sequence Diagram

%%{init: {'theme': 'neutral'}}%%
sequenceDiagram
    participant User
    participant LogDetails as LogDetails (Logs route)
    participant Event as DOM CustomEvent
    participant Home as Home (Chat surface)
    participant Storage as MothershipHandoffStorage
    participant Router as Next.js Router

    User->>LogDetails: Click "Troubleshoot in Chat"
    LogDetails->>LogDetails: "Build ChatContext {kind:'logs', executionId}"
    LogDetails->>Event: sendMothershipMessage(message, [context]) cancelable:true

    alt Chat is already mounted (same-page)
        Event->>Home: MOTHERSHIP_SEND_MESSAGE_EVENT
        Home->>Event: e.preventDefault() — claims event
        Home->>Home: sendMessage(message, undefined, contexts)
        Event-->>LogDetails: returns true (consumed)
        LogDetails->>LogDetails: early return (no navigation)
    else Chat not mounted (cross-route)
        Event-->>LogDetails: returns false (no consumer)
        LogDetails->>Storage: "store({message, contexts, timestamp})"
        Storage-->>LogDetails: true (stored)
        LogDetails->>Router: push(/workspace/.../home)
        Router->>Home: mount (!chatId)
        Home->>Storage: consume()
        Storage->>Storage: clear() atomically
        Storage-->>Home: "{message, contexts}"
        Home->>Home: sendMessage(message, undefined, contexts)
    end

%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
sequenceDiagram
    participant User
    participant LogDetails as LogDetails (Logs route)
    participant Event as DOM CustomEvent
    participant Home as Home (Chat surface)
    participant Storage as MothershipHandoffStorage
    participant Router as Next.js Router

    User->>LogDetails: Click "Troubleshoot in Chat"
    LogDetails->>LogDetails: "Build ChatContext {kind:'logs', executionId}"
    LogDetails->>Event: sendMothershipMessage(message, [context]) cancelable:true

    alt Chat is already mounted (same-page)
        Event->>Home: MOTHERSHIP_SEND_MESSAGE_EVENT
        Home->>Event: e.preventDefault() — claims event
        Home->>Home: sendMessage(message, undefined, contexts)
        Event-->>LogDetails: returns true (consumed)
        LogDetails->>LogDetails: early return (no navigation)
    else Chat not mounted (cross-route)
        Event-->>LogDetails: returns false (no consumer)
        LogDetails->>Storage: "store({message, contexts, timestamp})"
        Storage-->>LogDetails: true (stored)
        LogDetails->>Router: push(/workspace/.../home)
        Router->>Home: mount (!chatId)
        Home->>Storage: consume()
        Storage->>Storage: clear() atomically
        Storage-->>Home: "{message, contexts}"
        Home->>Home: sendMessage(message, undefined, contexts)
    end

_{Reviews (8): Last reviewed commit: "improvement(logs): use emcn Badge for th..." | Re-trigger Greptile}

Review follow-ups: - Same-route case (Cursor): LogDetailsContent is also embedded in the Chat resource panel, where router.push('/home') doesn't remount Home, so the mount-only handoff consume never fired. Generalize the existing sendMothershipMessage event to carry contexts and be cancelable: deliver straight to a mounted chat when one claims it, and only persist + navigate when none is listening. - Corrupted-entry tombstone (Greptile): consume now clears whenever any entry exists, so a malformed/expired handoff can't linger across future mounts. - Silent store failure (Greptile): only navigate when the handoff actually stored, so a failed write never strands the user on an empty chat.

waleedlatif1 · 2026-07-01T23:32:46Z

@greptile

waleedlatif1 · 2026-07-01T23:32:47Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 9a9a11a. Configure here.}

waleedlatif1 · 2026-07-01T23:35:58Z

@greptile

waleedlatif1 · 2026-07-01T23:35:59Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit a9b0812. Configure here.}

waleedlatif1 · 2026-07-01T23:45:09Z

@greptile

waleedlatif1 · 2026-07-01T23:45:10Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 4fad79e. Configure here.}

Aligns the log-details panel's labeled action buttons (View Snapshot, Troubleshoot in Chat) with the settings design language by swapping the emcn Button for the canonical Chip pill. variant='primary' preserves the prior filled emphasis; leftIcon keeps the icons canonical.

waleedlatif1 · 2026-07-01T23:57:50Z

@greptile

waleedlatif1 · 2026-07-01T23:57:51Z

@cursor review

Gate the mount-time handoff consume on `!chatId` so an existing `/chat/[chatId]` mount can't claim a pending handoff if navigation races — a handoff always targets a fresh chat.

waleedlatif1 · 2026-07-02T00:05:53Z

@greptile

waleedlatif1 · 2026-07-02T00:05:53Z

@cursor review

The detail-card rows all hovered to --surface-2, but the card itself is --surface-2, so the hover was a no-op in light mode and only showed in dark. It also implied clickability on static readout rows. Now only the clickable Run ID row hovers, using the canonical --surface-active token; static rows carry no hover.

waleedlatif1 · 2026-07-02T00:08:24Z

@greptile

waleedlatif1 · 2026-07-02T00:08:25Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

1 issue from previous review remains unresolved.

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 398d954. Configure here.}

Replaces the hand-rolled version span with the canonical Badge (variant='green' size='md', pixel-identical tokens), so all three detail badges (Level, Trigger, Version) render through the same component.

waleedlatif1 · 2026-07-02T00:13:40Z

@greptile

waleedlatif1 · 2026-07-02T00:13:41Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

1 issue from previous review remains unresolved.

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 462f4cd. Configure here.}

Two concrete regressions from the earlier Chip conversion (#5341): - Both chips used variant='primary' (the solid inverse-fill treatment), the heaviest chrome in the design system, reserved for a single standout action per context (Save, Upgrade, Add key) — never a peer among several row actions. Two solid pills stacked in a narrow side panel read as oversized. Switched both to the bare (default) chip, matching every analogous row action in Settings. - The Version badge was size='md' while its siblings (Level, Trigger) are size='sm' — an inconsistency. Aligned to 'sm'. Also folded the floating 'Troubleshoot in Chat' chip into the Details card as its own row (matching 'Snapshot' exactly) instead of leaving it orphaned below Workflow Output — every row in the card now shares one shape (label left, trailing content right), consistent top to bottom.

cursor Bot reviewed Jul 1, 2026

View reviewed changes

Comment thread apps/sim/app/workspace/[workspaceId]/home/home.tsx Outdated

greptile-apps Bot reviewed Jul 1, 2026

View reviewed changes

Comment thread apps/sim/lib/core/utils/browser-storage.ts

Comment thread apps/sim/app/workspace/[workspaceId]/logs/components/log-details/log-details.tsx Outdated

vercel Bot temporarily deployed to Preview July 1, 2026 23:32 Inactive

cursor Bot reviewed Jul 1, 2026

View reviewed changes

docs(logs): convert inline comments to TSDoc on declarations

a9b0812

vercel Bot temporarily deployed to Preview July 1, 2026 23:35 Inactive

cursor Bot reviewed Jul 1, 2026

View reviewed changes

waleedlatif1 mentioned this pull request Jul 1, 2026

v0.7.20: perf, ui improvements, fable 5, tables row size bump, blogs #5337

Merged

style(logs): match Troubleshoot button icon gap to View Snapshot sibling

4fad79e

vercel Bot temporarily deployed to Preview July 1, 2026 23:45 Inactive

cursor Bot reviewed Jul 1, 2026

View reviewed changes

vercel Bot temporarily deployed to Preview July 1, 2026 23:57 Inactive

cursor Bot reviewed Jul 1, 2026

View reviewed changes

Comment thread apps/sim/app/workspace/[workspaceId]/home/home.tsx Outdated

fix(chat): only consume troubleshoot handoff on the new-chat surface

42c53d0

Gate the mount-time handoff consume on `!chatId` so an existing `/chat/[chatId]` mount can't claim a pending handoff if navigation races — a handoff always targets a fresh chat.

vercel Bot temporarily deployed to Preview July 2, 2026 00:05 Inactive

vercel Bot temporarily deployed to Preview July 2, 2026 00:08 Inactive

cursor Bot reviewed Jul 2, 2026

View reviewed changes

Comment thread apps/sim/lib/core/utils/browser-storage.ts

cursor Bot reviewed Jul 2, 2026

View reviewed changes

improvement(logs): use emcn Badge for the version pill

462f4cd

Replaces the hand-rolled version span with the canonical Badge (variant='green' size='md', pixel-identical tokens), so all three detail badges (Level, Trigger, Version) render through the same component.

vercel Bot temporarily deployed to Preview July 2, 2026 00:13 Inactive

cursor Bot reviewed Jul 2, 2026

View reviewed changes

waleedlatif1 merged commit bca7f2c into staging Jul 2, 2026
12 checks passed

waleedlatif1 deleted the worktree-logs-troubleshoot-in-chat branch July 2, 2026 00:19

This was referenced Jul 2, 2026

fix(chat): scope troubleshoot handoff to its workspace #5344

Merged

fix(logs): right-size and reorganize log-detail action chips #5352

Merged

Uh oh!

Conversation

waleedlatif1 commented Jul 1, 2026

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor Bot commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

Uh oh!

greptile-apps Bot commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Sequence Diagram

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Jul 1, 2026

Uh oh!

waleedlatif1 commented Jul 1, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented Jul 1, 2026

Uh oh!

waleedlatif1 commented Jul 1, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented Jul 1, 2026

Uh oh!

waleedlatif1 commented Jul 1, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented Jul 1, 2026

Uh oh!

waleedlatif1 commented Jul 1, 2026

Uh oh!

Uh oh!

waleedlatif1 commented Jul 2, 2026

Uh oh!

waleedlatif1 commented Jul 2, 2026

Uh oh!

Uh oh!

waleedlatif1 commented Jul 2, 2026

Uh oh!

waleedlatif1 commented Jul 2, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented Jul 2, 2026

Uh oh!

waleedlatif1 commented Jul 2, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vercel Bot commented Jul 1, 2026 •

edited

Loading

cursor Bot commented Jul 1, 2026 •

edited

Loading

greptile-apps Bot commented Jul 1, 2026 •

edited

Loading